From: Rui Matos Date: Mon, 27 Oct 2014 15:45:31 +0000 (+0100) Subject: BackgroundCache: plug an Animation object leak X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~2009 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=260657c0b850112a56d9001abde49d364de95840;p=gnome-shell.git BackgroundCache: plug an Animation object leak We need to return early in case the animation file is the same, otherwise we'll create a new Animation object and leak the previous one. https://bugzilla.gnome.org/show_bug.cgi?id=739252 --- diff --git a/js/ui/background.js b/js/ui/background.js index 81d186eb1..82928e771 100644 --- a/js/ui/background.js +++ b/js/ui/background.js @@ -172,6 +172,7 @@ const BackgroundCache = new Lang.Class({ })); GLib.Source.set_name_by_id(id, '[gnome-shell] params.onLoaded'); } + return; } let animation = new Animation({ file: params.file });